Add support for generics in offloadand remove no_mangle attribute#159566
Draft
Sa4dUs wants to merge 3 commits into
Draft
Add support for generics in offloadand remove no_mangle attribute#159566Sa4dUs wants to merge 3 commits into
offloadand remove no_mangle attribute#159566Sa4dUs wants to merge 3 commits into
Conversation
rustbot
added
A-LLVM
This comment has been minimized.
This comment has been minimized.
bjorn3
reviewed
Jul 19, 2026
| // core/std/allocators/etc. For example symbols used to hook up allocation | ||
| // are not considered for export | ||
| let codegen_fn_attrs = tcx.codegen_fn_attrs(sym_def_id); | ||
| let is_extern = codegen_fn_attrs.contains_extern_indicator(); |
Member
There was a problem hiding this comment.
Perhaps contains_extern_indicator should return true for offload functions?
bjorn3
reviewed
Jul 19, 2026
| }); | ||
|
|
||
| // Write out the offload manifest of required generic kernel instantiations. | ||
| if let Some(path) = tcx.sess.opts.unstable_opts.offload.iter().find_map(|o| { |
Member
There was a problem hiding this comment.
This seems like something that should be done outside of this query. I think this query can be cached, in which case nothing would be written.
bjorn3
reviewed
Jul 19, 2026
| } | ||
|
|
||
| // A `HostMetadata` pass only exists to collect the set of generic kernel instantiations | ||
| // required by the host and write the offload manifest. |
Member
There was a problem hiding this comment.
Why does this even go through codegen_crate?
Member
|
Great improvement ( I'll review later). |
This comment has been minimized.
This comment has been minimized.
bjorn3
reviewed
Jul 23, 2026
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implements a 3rd pass where we collect kernel instantiations required by offload to work
also enforces consistent mangling for offload functions between host and device
closes: #150985
r? @ZuseZ4